Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lighting update issue caused when very tall one block tower is destroyed #180

Open
stackotter opened this issue Aug 17, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@stackotter
Copy link
Owner

The lighting underneath the tower remains darker than it should be (although not as dark as it would've been if it was still underneath the tower: 0). It seems like skylight levels aren't propagating correctly. To reproduce the issue, build a tower of blocks, disconnect and rejoin, and then break the tower. Each time a block is deleted, the sky light level at its old location
is 14 instead of 15, indicating that skylight levels aren't correctly propagating (they should be set to 15 if directly exposed to the sky, instead of propagating like block light levels would).

If you want to try fixing this issue, take a look at LightingEngine, it's extremely likely that the issue is somewhere in there. I'm happy to give you a helping hand in the Discord server if you want help understanding the code or where the issue might be. I'm pretty sure I know where the issue would be, but I'm leaving this issue for new contributors so that they can have some entry level issues to start with.

@stackotter stackotter added bug Something isn't working good first issue Good for newcomers labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant