Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for STX amount in signer key authorizations #4422

Closed
hstove opened this issue Feb 23, 2024 · 2 comments · Fixed by #4461
Closed

Add validation for STX amount in signer key authorizations #4422

hstove opened this issue Feb 23, 2024 · 2 comments · Fixed by #4461

Comments

@hstove
Copy link
Contributor

hstove commented Feb 23, 2024

In pox-4 we have authorizations (via pre-set authorizations or via signatures) around usage of a signer key, but those authorizations do not cover the amount of STX used.

These authorizations should include a new field, amount-ustx, which indicates the max amount of STX that can be used by a particular reward set.

Also related is #4417, which adds signer-key to stack-increase. That ticket will need to also validate that the new amount of STX locked (after the increase) does not exceed the amount-ustx included in the authorization.

@hstove hstove self-assigned this Feb 23, 2024
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Feb 23, 2024
@hstove hstove moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng Feb 23, 2024
@hstove
Copy link
Contributor Author

hstove commented Feb 23, 2024

Linking discussion: #4424

@hstove hstove moved this from Status: 📋 Backlog to Status: 💻 In Progress in Stacks Core Eng Feb 28, 2024
@hstove hstove linked a pull request Feb 29, 2024 that will close this issue
@saralab saralab moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Mar 1, 2024
@saralab saralab moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Mar 6, 2024
@saralab saralab closed this as completed Mar 6, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants