Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update block validation endpoint to return the processing time #5464

Closed
obycode opened this issue Nov 15, 2024 · 3 comments
Closed

Update block validation endpoint to return the processing time #5464

obycode opened this issue Nov 15, 2024 · 3 comments
Assignees
@obycode
Labels
locked tenure-extend
Milestone
3.1.0.0.1

Comments

@obycode
Copy link
Contributor

obycode commented Nov 15, 2024 •
edited
Loading

In addition to reporting if the block is valid, the node should also report the block cost. EDIT: it already reports the block costs.

In addition to reporting if the block is valid, the node should also report the processing time.

See #5434.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Nov 15, 2024
@jferrant
Copy link
Collaborator

Does it not already do this?

stacks-core/stackslib/src/net/api/postblock_proposal.rs

Line 146 in bac1b07

pub cost: ExecutionCost,

@obycode obycode assigned obycode and unassigned jferrant Nov 15, 2024
@obycode obycode changed the title Update block validation endpoint to return the cost Update block validation endpoint to return the processing time Nov 15, 2024
@obycode
Copy link
Contributor Author

obycode commented Nov 15, 2024

Does it not already do this?

Updated to add the processing time instead.

@aldur aldur added this to the Tenure extend milestone Nov 18, 2024
@aldur aldur moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng Nov 18, 2024
@obycode obycode mentioned this issue Nov 18, 2024
Merged
@obycode obycode moved this from Status: 📋 Backlog to Status: In Review in Stacks Core Eng Nov 18, 2024
@obycode obycode closed this as completed Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Nov 19, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@obycode obycode

Labels
locked tenure-extend
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
3.1.0.0.1
Development

No branches or pull requests
4 participants
@obycode @aldur @jferrant @blockstack-devops