Chore: Remove unnecessary sha2-asm dependency
#4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4435 +/- ##
===========================================
- Coverage 83.46% 65.01% -18.45%
===========================================
Files 448 448
Lines 324308 324308
===========================================
- Hits 270676 210844 -59832
- Misses 53632 113464 +59832 see 258 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jcnelson
approved these changes
Feb 27, 2024
kantai
approved these changes
Mar 1, 2024
kantai
force-pushed
the
chore/remove-sha2-asm
branch
from
1020ace to
3f8b1b6
Compare
jbencin
force-pushed
the
chore/remove-sha2-asm
branch
from
3f8b1b6 to
aa0f6d7
Compare
5 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
sha2-asmdependency from Clarity'sCargo.tomlfile. This does not actually remove thesha2-asmfrom our dependency tree, as it is still used transitively throughsha2. This was just pulling in an older version, which was not usedI've checked with
hyperfineand this PR does not affect performance