Use thiserror throughout testnet/stacks-node

[jferrant]

Made thiserror a workspace lib. I also checked and made sure no unsafe throughout even in the updated version.
Updated the custom fmt::Display implementations throughout testnet/stacks-node to use thiserror cause I love red <3

[hstove]

LGTM!

Question generally - I get that this is very useful for errors, but is there anything about thiserror that is only relevant for errors? To me, this seems to just be a handy mechanism for implementing Display on anything.

Is it mainly that the library also provides optional macros for source, from, etc?

[jferrant]

LGTM!

Question generally - I get that this is very useful for errors, but is there anything about thiserror that is only relevant for errors? To me, this seems to just be a handy mechanism for implementing Display on anything.

Is it mainly that the library also provides optional macros for source, from, etc?

Yes it implements source, from, display, etc very easily. It just cleans up the code a little bit and makes it easier to add error codes :) It isn't as noticeable in stacks-node vs the stackslib code, but starting small to make it easier to review and to get buy-in before I commit to changing it everywhere

[jcnelson]

I also checked and made sure no unsafe throughout even in the updated version.

Thanks for doing the due diligence on this!

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.