Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better error logging with signerdb insert error #5475

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Nov 18, 2024

This is a small QOL change. When the signer hits an error when inserting into signerDB, the code panics without logging the specific error that happened.

This change does two things:

  • Adds an explicit error log, because panic! doesn't actually create an error-level log
  • Includes the exception in the log message

@hstove hstove requested a review from a team as a code owner November 18, 2024 16:26
@hstove hstove requested review from obycode and jferrant November 18, 2024 16:27
@hstove hstove enabled auto-merge November 18, 2024 16:40
@hstove hstove added this pull request to the merge queue Nov 18, 2024
Merged via the queue into develop with commit dbfd363 Nov 18, 2024
11 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants