Refactor #12
Refactor #12
Conversation
* Add parameters to override all yumrepo resource baseurl and descr properties * Add enable_products and enable_deps parameters * Replace rpm_gpg_key defined type with gpg_key provider * Add parameter to params class to allow hiera to override base URL for all repos * Update to correct puppetlabs GPG key * Remove pper_installed fact and rely on puppetlabs-stdlib fact "is_pe" * Remove os_maj_version fact and fallback to same logic in params class if operatingsystemmajrelease is not available * Completely refactor unit tests into shared examples * Use puppet-lint Rake task configuration * Added dependencies on puppetlabs-stdlib and treydock-gpg_key * Add all supported puppet versions to travis-ci tests
|
I forked treydock's work and added support for the puppet collection repo. see https://github.com/mmckinst/puppet-module-puppetlabs_yum . |
|
Thanks Michael! I'll make a few more changes and send an updated pull request. |
|
@treydock you have rights to fix this up. Is there anything you're waiting on? |
|
@stahnma You gave me commit access as well. I looked at the module this weekend and just decided to rewrite it and greatly simplify it. I've added support for PC1 which is the default but also retain support for what I called the puppet3 repo but is disabled by default. https://github.com/mmckinst/puppet-module-puppetlabs_yum/tree/in_with_the_new Let me know your thoughts and I can change things and document things in the README and merge it if you want. |
|
I'm pretty happy with your changes. If you'd rather keep your own module and I can just point people to it, that's fine too. |
Should resolve #9 and #10