Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github): add support for only using the REST API #1

Merged
merged 6 commits into from
Apr 11, 2023
Merged

feat(github): add support for only using the REST API #1

merged 6 commits into from
Apr 11, 2023

Conversation

RobertCraigie
Copy link
Member

@RobertCraigie RobertCraigie commented Apr 10, 2023 •
edited
Loading

This PR adds support for using the REST API instead of the GraphQL API as the GraphQL API doesn't support fine-grained personal access tokens yet.

This can be specified in the CLI, e.g.

release-please release-pr 
  --token=$GITHUB_TOKEN \
  --repo-url=<owner>/<repo>
  --use-graphql=false

TODO:

RobertCraigie
RobertCraigie commented Apr 10, 2023
View reviewed changes
src/github.ts Outdated Show resolved Hide resolved
@RobertCraigie RobertCraigie marked this pull request as ready for review April 10, 2023 14:44
rattrayalex
rattrayalex approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@rattrayalex rattrayalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, that was quick!

src/github.ts Outdated Show resolved Hide resolved
@RobertCraigie RobertCraigie merged commit d68bc9d into main Apr 11, 2023
@RobertCraigie RobertCraigie deleted the robert/use-rest-api branch April 11, 2023 09:51
marcel-stainless added a commit that referenced this pull request Aug 21, 2023
@marcel-stainless
Merge pull request #1 from marcel-stainless/add-reviewers-option
c5d0304 
add options for reviewers to request
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rattrayalex rattrayalex rattrayalex approved these changes

@jedwards1211 jedwards1211 Awaiting requested review from jedwards1211

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertCraigie @rattrayalex