Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always update release PR, even if title/body do not change #187

Merged
merged 1 commit into from
Nov 7, 2024
Merged

always update release PR, even if title/body do not change #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,15 +1146,15 @@ export class Manifest {
existing: PullRequest,
pullRequest: ReleasePullRequest
): Promise<PullRequest | undefined> {
// If unchanged, no need to push updates
// If the body and title are unchanged, update anyways since some commits that are not included in the PR body
// may have been added
if (
existing.title === pullRequest.title.toString() &&
existing.body === pullRequest.body.toString()
) {
this.logger.info(
`PR https://github.com/${this.repository.owner}/${this.repository.repo}/pull/${existing.number} remained the same`
`PR https://github.com/${this.repository.owner}/${this.repository.repo}/pull/${existing.number} remained the same - continuing anyways`
);
return undefined;
}

const updatedPullRequest = await this.github.updatePullRequest(
Expand Down
Loading