-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can a UBI image variant be added? #348
Comments
@IdanAdar can you please add description and also reasoning? |
For compliance purposes, some cloud providers require images to be based on UBI by RedHat. To that end, we'd like Reloader to offer also an image based on UBI as base image next to distroless @rasheedamir, and sorry for gettin back late to you. :) |
Got it @IdanAdar PRs are welcome; we do lots of managed OpenShift as well; so, it will be a great addition |
@rasheedamir Any guiding tips how this should be done for Reloader specifically? |
@rasheedamir Any guiding tips how this should be done for Reloader specifically? |
We're building reloader from source internally with other build image as well as base image. To do that we use the BUILDER_IMAGE and BASE_IMAGE parameters to the Makefile. Perhaps you can use the same?
Have a look at the Makefile. |
If you don't want to build from source like we do, you can also use the binary from the published image in a new Dockerfile like this:
Build with |
@IdanAdar did you manage to build the image and/or create a PR to publish UBI-based reloader? |
I could not, no. |
What model did you try and what problem did you run into? |
I also need this, for compliance reasons, so I have opened a PR. Happy to change whatever is needed to get it in. |
For compliance purposes, some cloud providers require images to be based on UBI by RedHat. To that end, we'd like Reloader to offer also an image based on UBI as base image next to distroless
The text was updated successfully, but these errors were encountered: