Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can a UBI image variant be added? #348

Closed
IdanAdar opened this issue Oct 18, 2022 · 11 comments
Closed

Can a UBI image variant be added? #348

IdanAdar opened this issue Oct 18, 2022 · 11 comments
Labels
kind/enhancement New feature or request workflow/todo

Comments

@IdanAdar
Copy link
Contributor

IdanAdar commented Oct 18, 2022

For compliance purposes, some cloud providers require images to be based on UBI by RedHat. To that end, we'd like Reloader to offer also an image based on UBI as base image next to distroless

@rasheedamir
Copy link
Member

@IdanAdar can you please add description and also reasoning?

@IdanAdar
Copy link
Contributor Author

For compliance purposes, some cloud providers require images to be based on UBI by RedHat. To that end, we'd like Reloader to offer also an image based on UBI as base image next to distroless @rasheedamir, and sorry for gettin back late to you. :)

@rasheedamir
Copy link
Member

Got it @IdanAdar PRs are welcome; we do lots of managed OpenShift as well; so, it will be a great addition

@rasheedamir rasheedamir added the kind/enhancement New feature or request label Dec 17, 2022
@IdanAdar
Copy link
Contributor Author

IdanAdar commented Jan 6, 2023

@rasheedamir Any guiding tips how this should be done for Reloader specifically?

@IdanAdar
Copy link
Contributor Author

@rasheedamir Any guiding tips how this should be done for Reloader specifically?

@smuda
Copy link
Contributor

smuda commented Mar 13, 2023

We're building reloader from source internally with other build image as well as base image. To do that we use the BUILDER_IMAGE and BASE_IMAGE parameters to the Makefile. Perhaps you can use the same?

$ DOCKER_IMAGE=my.image.local/reloader \
   ARCH=amd64 \
   BASE_IMAGE=docker.io/redhat/ubi8-micro:latest \
   make build-image

Have a look at the Makefile.

@smuda
Copy link
Contributor

smuda commented Mar 13, 2023

If you don't want to build from source like we do, you can also use the binary from the published image in a new Dockerfile like this:

FROM docker.io/stakater/reloader:v1.0.15 as SRC

FROM docker.io/redhat/ubi8-micro:latest

WORKDIR /
COPY --from=SRC /manager .
USER 65532:65532

# Port for metrics and probes
EXPOSE 9090

ENTRYPOINT ["/manager"]

Build with docker build . -t my-reloader:v1.0.15

@smuda
Copy link
Contributor

smuda commented Jul 8, 2023

@IdanAdar did you manage to build the image and/or create a PR to publish UBI-based reloader?

@IdanAdar
Copy link
Contributor Author

I could not, no.

@smuda
Copy link
Contributor

smuda commented Jul 28, 2023

What model did you try and what problem did you run into?

@daniel-butler-irl
Copy link
Contributor

daniel-butler-irl commented Oct 18, 2023

I also need this, for compliance reasons, so I have opened a PR. Happy to change whatever is needed to get it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request workflow/todo
Projects
None yet
Development

No branches or pull requests

4 participants