Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] ArgoCD "restart" instead of starting a new rollout for blue/green. #591

Closed
im-aIex opened this issue Dec 20, 2023 · 6 comments
Closed
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed

Comments

@im-aIex
Copy link

im-aIex commented Dec 20, 2023

Is your feature request related to a problem? Please describe.
When using long-lived / manual blue/green rollouts it currently creates a new green rollout and requires time / manual intervention to make it to the blue pods. Having the option to run a "restart" would allow all pods in an existing blue/green rollout to be recreated and still maintain HA.

Describe the solution you'd like
Add an option (annotation/strategy) to run a "restart" instead of just causing an update that forces a new rollout.

Additional context
See Restarting Rollout Pods for more details.

Both of these mechanisms updates the Rollout's .spec.restartAt to the current time in the form of a RFC 3339 formatted UTC string (e.g. 2020-03-30T21:19:35Z), which indicates to the Rollout controller that all of a Rollout's Pods should have been created after this timestamp.

@im-aIex im-aIex added the kind/enhancement New feature or request label Dec 20, 2023
@MuneebAijaz MuneebAijaz added the kind/help wanted Extra attention is needed label Dec 27, 2023
@jangeja
Copy link
Contributor

jangeja commented Aug 7, 2024

Same applies for canary rollouts.

If we have a long running canary, and we update a secret, only the canary gets updated.

This can present itself a major problem if the stable RS is not reloaded with the updated secrets/CMs.

Can probably fix this with a simple change to the updateRollout Callback

Ill push a PR shortly

@jangeja
Copy link
Contributor

jangeja commented Aug 21, 2024

This can be closed, once a release is cut witht he merged PR.

@jangeja
Copy link
Contributor

jangeja commented Aug 22, 2024

@MuneebAijaz whats the release cadence for reloader ? Would love to close this issue out!

@MuneebAijaz
Copy link
Contributor

@jangeja images tagged as merge-728 https://github.com/stakater/Reloader/pkgs/container/reloader should have this change for immediate use. as for the release, i was hoping to resolve charts release workflow as well before making a manual release but could be done earlier, let's see.

@jangeja
Copy link
Contributor

jangeja commented Aug 26, 2024

Thank you! Will use the merge-728 image until a release is made.

@im-aIex
Copy link
Author

im-aIex commented Aug 28, 2024

Fix released in v1.1.0

@im-aIex im-aIex closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request kind/help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants