-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vignettes and readme for 1.0 #590
Comments
Also, remember that the opencl vignette doesn't run unless the |
Yeah, I will run it with my GPU whenever we will do that. Not a problem. |
The only issue is that CRAN allows each package to have only a single maintainer at a time and that person has to submit the releases. So I can't be the maintainer but have you generate one of the vignettes (as far as I know, but maybe there's a workaround). So I think that gives us a few alternatives: (a) I'm the CRAN maintainer and the vignettes are all generated on my mac I don't really care who the maintainer is (I'm happy to do it or not do it), so I guess if we want to make sure the opencl vignette is generated by you then we should do option (b) or (c). I'm ok with either of those options. |
We could also just not include the OpenCL vignette right? |
Yeah that's true. We could have the OpenCL vignette only be on the website and not on CRAN. That may be the best option. |
I will add this to PR #595. I think we can put the OpenCL vignette in a subdirectory and have CRAN ignore it but pkgdown put it online. |
@jgabry Hi Jonah, quick question from the sidelines - do you plan to put |
Yes! There are only a few more issues to address before we do a v1.0 release: https://github.com/stan-dev/cmdstanr/milestone/2 And really only two of those issues involve much work (#582 and #534). |
Hi @jgabry , so from our side we would be very interested to see |
@jgabry @rok-cesnovar any thoughts/feedback? |
Hey, sorry, meant to respond a few days ago, but it slipped my mind. Thanks for reaching out and offering the help!! Much appreciated. As far as getting cmdstanr on CRAN, we have a 1.0.0 milestone (https://github.com/stan-dev/cmdstanr/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22v1.0.0+-+release%22). What we are mostly lacking at this point is more documentation, vignettes and examples. Outside of that, its just a few minor features that we could also discuss bumping to future releases. I mean to do a push on some of the smaller bugfixes/features, but have been pretty busy in the last weeks. Happy to schedule a call to discuss how we could push this over the line. |
Thanks a lot @rok-cesnovar - looking forward to our chat! |
@jgabry @rok-cesnovar I'd be willing to help update the documentation, vignettes, and examples, particularly for working with draws. It seems like there are a few related issues currently open that concern postprocessing draws (e.g., #632 , #582 , #641 ). I'd be interested to hear more about how I could help given where things stand. |
I think we primarily need a few more vignettes with basic examples. So just run sampling on some model and then:
I don't think it needs to be anything fancy. |
Thanks for the help offers. I agree with @rok-cesnovar that's it's mostly doc improvements / vignettes that we need. Any help with those would be much appreciated! (I've been overwhelmed with other work recently so I haven't had much of a chance to do those things myself yet.) |
A few other things that could use more doc / vignette:
|
For this, I think right now there's no doc for how to use functions that are compiled (the
For this, there's an example of using |
@jgabry We hadn't discussed working together. I was planning on putting together something that demonstrated working with draws in various formats, including draws_rvars. However, I'd be willing to collaborate if others have already started something. |
Hi guys, we are just talking again about |
question: where is the R community on R-universe as a CRAN alternative? CRAN has been a nightmare for the project - not sure it's worth it. |
Yeah I guess for our pharma industry environment things are moving slower than elsewhere, so we would still be very motivated to get our package (and therefore |
One of the last things we should do before the 1.0 release is to update the main vignette, which currently refers to CmdStanR being in beta.
Also the readme needs to be updated
The text was updated successfully, but these errors were encountered: