Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vignettes and readme for 1.0 #590

Open
jgabry opened this issue Nov 9, 2021 · 24 comments
Open

Update vignettes and readme for 1.0 #590

jgabry opened this issue Nov 9, 2021 · 24 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jgabry
Copy link
Member

jgabry commented Nov 9, 2021

One of the last things we should do before the 1.0 release is to update the main vignette, which currently refers to CmdStanR being in beta.

Also the readme needs to be updated

@jgabry jgabry added the documentation Improvements or additions to documentation label Nov 9, 2021
@jgabry jgabry added this to the v1.0.0 - release milestone Nov 9, 2021
@jgabry jgabry self-assigned this Nov 9, 2021
@jgabry jgabry changed the title Update vignette for 1.0 Update vignettes for 1.0 Nov 10, 2021
@jgabry
Copy link
Member Author

jgabry commented Nov 10, 2021

Also, remember that the opencl vignette doesn't run unless the CMDSTANR_OPENCL_TESTS environment variable is set. And when publishing the OPENCL vignette to the website with v1.0 (and eventually to CRAN) we need to decide if we want it to be run on linux or if it's ok if I generate it on mac (does it matter for demonstrating the timings?).

@rok-cesnovar
Copy link
Member

Yeah, I will run it with my GPU whenever we will do that. Not a problem.

@jgabry
Copy link
Member Author

jgabry commented Nov 10, 2021

The only issue is that CRAN allows each package to have only a single maintainer at a time and that person has to submit the releases. So I can't be the maintainer but have you generate one of the vignettes (as far as I know, but maybe there's a workaround). So I think that gives us a few alternatives:

(a) I'm the CRAN maintainer and the vignettes are all generated on my mac
(b) You're the CRAN maintainer and the vignettes are all generated on whatever linux machine you're using
(c) We don't include the vignettes with the CRAN package, just links to the ones on the CmdStanR website. This allows either of us to be CRAN maintainer and either of us to upload any of the vignettes to the CmdStanR website.

I don't really care who the maintainer is (I'm happy to do it or not do it), so I guess if we want to make sure the opencl vignette is generated by you then we should do option (b) or (c). I'm ok with either of those options.

@rok-cesnovar
Copy link
Member

We could also just not include the OpenCL vignette right?

@jgabry
Copy link
Member Author

jgabry commented Nov 10, 2021

Yeah that's true. We could have the OpenCL vignette only be on the website and not on CRAN. That may be the best option.

@jgabry
Copy link
Member Author

jgabry commented Nov 10, 2021

Yeah that's true. We could have the OpenCL vignette only be on the website and not on CRAN. That may be the best option.

I will add this to PR #595. I think we can put the OpenCL vignette in a subdirectory and have CRAN ignore it but pkgdown put it online.

@jgabry jgabry changed the title Update vignettes for 1.0 Update vignettes and readme for 1.0 Nov 11, 2021
@danielinteractive
Copy link

@jgabry Hi Jonah, quick question from the sidelines - do you plan to put cmdstanr on CRAN soon?

@jgabry
Copy link
Member Author

jgabry commented Mar 18, 2022

do you plan to put cmdstanr on CRAN soon?

Yes!

There are only a few more issues to address before we do a v1.0 release:

https://github.com/stan-dev/cmdstanr/milestone/2

And really only two of those issues involve much work (#582 and #534).

@danielinteractive
Copy link

Hi @jgabry , so from our side we would be very interested to see cmdstanr on CRAN to enable downstream packages to be on CRAN too.
What do you think - where could we help with tackling cmdstanr issues? I would be happy also to have a quick video call with you / the team to get started. Thanks!

@danielinteractive
Copy link

@jgabry @rok-cesnovar any thoughts/feedback?

@rok-cesnovar
Copy link
Member

Hey, sorry, meant to respond a few days ago, but it slipped my mind. Thanks for reaching out and offering the help!! Much appreciated.

As far as getting cmdstanr on CRAN, we have a 1.0.0 milestone (https://github.com/stan-dev/cmdstanr/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22v1.0.0+-+release%22). What we are mostly lacking at this point is more documentation, vignettes and examples. Outside of that, its just a few minor features that we could also discuss bumping to future releases. I mean to do a push on some of the smaller bugfixes/features, but have been pretty busy in the last weeks.

Happy to schedule a call to discuss how we could push this over the line.

@danielinteractive
Copy link

Thanks a lot @rok-cesnovar - looking forward to our chat!

@dmuck
Copy link

dmuck commented Nov 11, 2022

@jgabry @rok-cesnovar I'd be willing to help update the documentation, vignettes, and examples, particularly for working with draws.

It seems like there are a few related issues currently open that concern postprocessing draws (e.g., #632 , #582 , #641 ).

I'd be interested to hear more about how I could help given where things stand.

@rok-cesnovar
Copy link
Member

rok-cesnovar commented Nov 11, 2022

I think we primarily need a few more vignettes with basic examples. So just run sampling on some model and then:

I don't think it needs to be anything fancy.

@jgabry
Copy link
Member Author

jgabry commented Nov 11, 2022

Thanks for the help offers. I agree with @rok-cesnovar that's it's mostly doc improvements / vignettes that we need. Any help with those would be much appreciated! (I've been overwhelmed with other work recently so I haven't had much of a chance to do those things myself yet.)

@jgabry
Copy link
Member Author

jgabry commented Nov 15, 2022

A few other things that could use more doc / vignette:

@gravesti gravesti mentioned this issue Nov 16, 2022
2 tasks
@gravesti
Copy link
Contributor

I've taken a stab at starting a new vignette with a few more examples for $summary in #791.
Did you already start something @dmuck ?

@jgabry
Copy link
Member Author

jgabry commented Nov 16, 2022

A few other things that could use more doc / vignette:

For this, I think right now there's no doc for how to use functions that are compiled (the compile method argument compile_standalone is documented, but not how to access the functions once they are compiled (i.e., via mod$functions$foo()).

For this, there's an example of using log_prob at ?"fit-method-log_prob" but the example just passes in a vector of numbers for upars. But just typing in the upars manually is pretty much impossible to do for a real example and I think we need to demonstrate how the user can use these methods together, i.e. log_prob in conjunction with unconstrain_pars (and create the structured list for unconstrain_pars conveniently). @andrjohns Do you already have some examples of this from when you were working on implementing it?

@dmuck
Copy link

dmuck commented Nov 18, 2022

I've taken a stab at starting a new vignette with a few more examples for $summary in #791. Did you already start something @dmuck ?

Not yet, @gravesti. I should be able to start something next week.

@jgabry
Copy link
Member Author

jgabry commented Nov 18, 2022

I've taken a stab at starting a new vignette with a few more examples for $summary in #791.
Did you already start something @dmuck ?

Thanks for starting this. Are you and @dmuck planning on working together on this or on two separate things?

@dmuck
Copy link

dmuck commented Nov 20, 2022

@jgabry We hadn't discussed working together. I was planning on putting together something that demonstrated working with draws in various formats, including draws_rvars.

However, I'd be willing to collaborate if others have already started something.

@danielinteractive
Copy link

Hi guys, we are just talking again about cmdstanr getting to CRAN - anything we can help you out with this? (Background is that we have a package using cmdstanr, so we cannot push that to CRAN before cmdstanr is on CRAN :-))

@mitzimorris
Copy link
Member

mitzimorris commented Feb 15, 2023

question: where is the R community on R-universe as a CRAN alternative? CRAN has been a nightmare for the project - not sure it's worth it.

@danielinteractive
Copy link

Yeah I guess for our pharma industry environment things are moving slower than elsewhere, so we would still be very motivated to get our package (and therefore cmdstanr) to CRAN :-) And as mentioned above, we are happy to help to work on issues etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants