Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Integration fails with jest 22 + node.js 4 on @std/esm 0.19.1 #210

Closed
JLHwung opened this issue Jan 6, 2018 · 2 comments
Closed

Integration fails with jest 22 + node.js 4 on @std/esm 0.19.1 #210

JLHwung opened this issue Jan 6, 2018 · 2 comments
Labels

Comments

@JLHwung
Copy link

JLHwung commented Jan 6, 2018

It's me again. 😁

After upgrading to 0.19.1, node.js 4 complains that

SyntaxError: Unexpected token {
      
      at _load_jsdom (node_modules/jest-environment-jsdom/build/index.js:16:41)

node 6, 8, 9 is unaffected. I guess some unbabelified code is executed.

CI Result is here.

@jdalton
Copy link
Member

jdalton commented Jan 6, 2018

Hi @JLHwung!

I don't think this is a @std/esm issue.
Jest v22 dropped Node 4 support and JSDOM now requires Node 6 or higher.

Let me know if that's not it.

@jdalton jdalton closed this as completed Jan 6, 2018
@jdalton jdalton added the invalid label Jan 6, 2018
@JLHwung
Copy link
Author

JLHwung commented Jan 7, 2018

Hi @jdalton
While Jest v22 dropped Node 4 support due to jsdom, unofficial node 4 support is added jestjs/jest#5134 so we can use jest if test does not depend on JSDOM.

The test passes when specifying

testEnvironment: "node"

on jest config.

I should have specified testEnvironment earlier. Thank you for your great help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants