Add async support to Module class
#1988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younes-io
changed the title
Module classasync support to Module class
|
Thanks a lot @younes-io ! Tagging @CyrusNuevoDia , the async expert here :D |
|
Thanks @younes-io this is great! 2 questions --
|
CyrusNuevoDia
requested changes
Dec 25, 2024
Comment on lines
+66
to
+70
| for k, v in kwargs.items(): | ||
| if is_async_arg(v): | ||
| async_kwargs[k] = await v | ||
| else: | ||
| async_kwargs[k] = v |
There was a problem hiding this comment.
Can you make this use gather so they resolve concurrently?
Thank you for looking into this.. The short answer would be: 1 - Not yet (working on it) This commit is just the first step.. I'm trying to do this step by step and write tests to avoid regressions because it could get tricky |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds native async support to DSPy's
Moduleclass, making it easier to work with async operations. Instead of usingasyncify, you can now writeasyncmodules naturally:aforwardmethod for async implementationsPlease, let me know your feedback on this initial async implementation..
Should fix #1975 (WIP)