Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autoupdates for pacman #189

Closed
xyloflake opened this issue Jul 30, 2024 · 3 comments · Fixed by #192
Closed

Implement autoupdates for pacman #189

xyloflake opened this issue Jul 30, 2024 · 3 comments · Fixed by #192
Assignees
Labels

Comments

@xyloflake
Copy link
Contributor

xyloflake commented Jul 30, 2024

Description

Currently, auto-updates on Linux are only functional with .deb, .rpm, or .appimage formats due to limitations in both app-builder-lib and electron-updater.

Challenges

  • Incompatible Update Handling: electron-updater assumes that non-Debian platforms have the dpkg command available and attempts to update via .deb files. This leads to issues on systems like Arch Linux, where users encounter a message stating, "An update has been downloaded and will be installed on exit." Upon closing the app, it prompts for sudo access but fails to complete the update, often resulting in the app disappearing without warning. Users may find themselves stuck in a loop, expecting the app to auto-update when it does not.

  • Lack of Package Manager Detection: There is no current implementation in electron-updater for detecting the appropriate package manager for updates. This lack of detection creates confusion in selecting the correct files for auto-updates and determining which package manager to use for the update process.

Edit: Found a way to fetch the package-type

@xyloflake xyloflake added the bug label Jul 30, 2024
@xyloflake xyloflake self-assigned this Jul 30, 2024
@xyloflake xyloflake changed the title Make autoupdates work on non deb/rpm/appimage platforms Implement autoupdates for pacman Jul 30, 2024
@xyloflake
Copy link
Contributor Author

Status: 100% implemented ✅

Bug discovered 🔴

Window is tagged as unresponsive when waiting for the updater to finish. Fixing soon.

Demo

Screencast.from.2024-07-31.19-32-58.webm

@xyloflake
Copy link
Contributor Author

Pushed 0ec5a95

However, the freezing still occurs while autoupdating.

@xyloflake
Copy link
Contributor Author

electron-userland/electron-builder#8394

Made a PR in electron-builder. Closing this and creating a separate issue for the freeze bug

@xyloflake xyloflake added enhancement feature new feature and removed bug labels Aug 3, 2024
@xyloflake xyloflake linked a pull request Aug 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant