Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore):uniform column name pattern #1077

Merged
merged 4 commits into from
Aug 30, 2022
Merged

fix(datastore):uniform column name pattern #1077

merged 4 commits into from
Aug 30, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 30, 2022 •
edited
Loading

Description

closes: #1072

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Aug 30, 2022
@goldenxinxing goldenxinxing self-assigned this Aug 30, 2022
waynelwz
waynelwz approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 9275e0d into star-whale:main Aug 30, 2022
@goldenxinxing goldenxinxing deleted the fix/uniform_column_name_pattern branch September 13, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynelwz waynelwz waynelwz approved these changes

@xuchuan xuchuan Awaiting requested review from xuchuan

Assignees

@goldenxinxing goldenxinxing

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uniform naming pattern for datastore at python and java
3 participants
@goldenxinxing @waynelwz @tianweidut