Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): rename manifest field of runtime to image #1105

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Sep 2, 2022

Description

rename manifest field of runtime to image to make the semantic clear

image
image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3 milestone Sep 2, 2022
@anda-ren anda-ren self-assigned this Sep 2, 2022
@jialeicui
Copy link
Contributor

add @tianweidut

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit b27053b into star-whale:main Sep 5, 2022
dreamlandliu pushed a commit to dreamlandliu/starwhale that referenced this pull request Sep 5, 2022
@anda-ren anda-ren deleted the runtime_image_rename branch October 11, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants