Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): remove email field of user #1107

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Sep 2, 2022

Description

in current business context , email info only exists for saas users. Email related code should not be present in community version. The front end should get saas user information using saas API profile( pr: https://github.com/star-whale/cloud-registration/pull/38)

image
image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3 milestone Sep 2, 2022
@anda-ren anda-ren self-assigned this Sep 2, 2022
@anda-ren anda-ren changed the title refactor(controller): remove user email population from saas refactor(controller): remove email field of user Sep 2, 2022
Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit b77d4b7 into star-whale:main Sep 5, 2022
dreamlandliu pushed a commit to dreamlandliu/starwhale that referenced this pull request Sep 5, 2022
@anda-ren anda-ren deleted the move_email_to_saas branch September 5, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants