Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(client): fix model eval info output #1110

Merged
merged 8 commits into from
Sep 2, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 2, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1110 (cac5085) into main (cbd0602) will increase coverage by 7.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
+ Coverage   72.24%   79.52%   +7.28%     
==========================================
  Files          62       62              
  Lines        6805     6807       +2     
==========================================
+ Hits         4916     5413     +497     
+ Misses       1889     1394     -495     
Flag Coverage Δ
standalone 79.52% <100.00%> (+7.28%) ⬆️
unittests 79.52% <100.00%> (+7.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/model.py 84.40% <100.00%> (+52.16%) ⬆️
client/starwhale/core/eval/model.py 77.16% <100.00%> (+35.99%) ⬆️
client/starwhale/core/runtime/model.py 69.92% <0.00%> (+0.19%) ⬆️
client/starwhale/utils/fs.py 75.86% <0.00%> (+0.86%) ⬆️
client/starwhale/core/runtime/store.py 94.11% <0.00%> (+2.94%) ⬆️
client/starwhale/base/cloud.py 69.44% <0.00%> (+3.70%) ⬆️
client/starwhale/base/bundle.py 91.24% <0.00%> (+5.10%) ⬆️
client/starwhale/core/job/scheduler.py 31.57% <0.00%> (+7.01%) ⬆️
client/starwhale/base/view.py 82.88% <0.00%> (+9.62%) ⬆️
client/starwhale/core/model/model.py 86.66% <0.00%> (+14.22%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut changed the title fix(client): add unit test bug(client): fix model eval info output Sep 2, 2022
@tianweidut tianweidut merged commit c35707b into star-whale:main Sep 2, 2022
@goldenxinxing goldenxinxing deleted the fix/add_unit_test branch September 13, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants