Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(controller): add UT, remove wal from jacoco report, adjust UT ci #1147

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Sep 8, 2022

Description

add UT, remove wal from jacoco report, adjust UT ci

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1147 (63dd068) into main (2370d91) will decrease coverage by 11.44%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##               main    #1147       +/-   ##
=============================================
- Coverage     73.99%   62.55%   -11.45%     
- Complexity      796      828       +32     
=============================================
  Files           205      142       -63     
  Lines         10778     3872     -6906     
  Branches        419      419               
=============================================
- Hits           7975     2422     -5553     
+ Misses         2672     1306     -1366     
- Partials        131      144       +13     
Flag Coverage Δ
controller 62.55% <50.00%> (+2.55%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../task/status/watchers/log/TaskLogK8sCollector.java 67.74% <0.00%> (+67.74%) ⬆️
...ava/ai/starwhale/mlops/reporting/ReportedTask.java 75.00% <0.00%> (+75.00%) ⬆️
.../ai/starwhale/mlops/storage/fs/FileStorageEnv.java 0.00% <0.00%> (ø)
...s/domain/swds/objectstore/StorageAccessParser.java 43.47% <100.00%> (+43.47%) ⬆️
...e/mlops/schedule/k8s/K8sResourcePoolConverter.java 90.90% <100.00%> (ø)
client/starwhale/utils/debug.py
client/starwhale/core/job/dag.py
client/starwhale/utils/flatten.py
client/starwhale/core/eval/store.py
client/starwhale/api/_impl/job.py
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit 95f381f into star-whale:main Sep 8, 2022
@anda-ren anda-ren deleted the ut2 branch October 11, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants