Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): add unit test for StorageAccessServiceS3 #1155

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Sep 8, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1155 (53ede14) into main (95f381f) will decrease coverage by 11.06%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1155       +/-   ##
=============================================
- Coverage     74.90%   63.84%   -11.07%     
- Complexity      828      847       +19     
=============================================
  Files           205      142       -63     
  Lines         10780     3872     -6908     
  Branches        419      419               
=============================================
- Hits           8075     2472     -5603     
+ Misses         2561     1252     -1309     
- Partials        144      148        +4     
Flag Coverage Δ
controller 63.84% <ø> (+1.29%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/runtime/model.py
client/starwhale/api/_impl/dataset/mnist.py
client/starwhale/core/dataset/type.py
client/starwhale/api/_impl/metric.py
client/starwhale/core/project/view.py
client/starwhale/api/_impl/job.py
client/starwhale/core/eval/executor.py
client/starwhale/mngt/__init__.py
client/starwhale/utils/venv_pack.py
client/starwhale/utils/flatten.py
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 63fe939 into star-whale:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants