Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(controller): unit test for user classes and some tiny change #1159

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 8, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added this to the v0.3 milestone Sep 8, 2022
@dreamlandliu dreamlandliu self-assigned this Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1159 (f30fdd9) into main (3c7351a) will decrease coverage by 10.63%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1159       +/-   ##
=============================================
- Coverage     75.38%   64.75%   -10.64%     
- Complexity      848      862       +14     
=============================================
  Files           205      142       -63     
  Lines         10780     3876     -6904     
  Branches        419      419               
=============================================
- Hits           8127     2510     -5617     
+ Misses         2506     1220     -1286     
+ Partials        147      146        -1     
Flag Coverage Δ
controller 64.75% <100.00%> (+0.86%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arwhale/mlops/domain/user/SystemRoleConvertor.java 100.00% <100.00%> (+100.00%) ⬆️
...starwhale/mlops/domain/user/UserRoleConvertor.java 100.00% <100.00%> (+100.00%) ⬆️
client/starwhale/core/job/model.py
client/starwhale/utils/error.py
client/starwhale/api/_impl/dataset/mnist.py
client/starwhale/api/_impl/model.py
client/starwhale/utils/venv_pack.py
client/starwhale/base/bundle_copy.py
client/starwhale/base/mixin.py
client/starwhale/base/type.py
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 56e3557 into star-whale:main Sep 9, 2022
@dreamlandliu dreamlandliu deleted the ut/test_user branch January 6, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants