Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datastore): make ObjectStore a proxy of StorageAccessService #1170

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Sep 9, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1170 (63f2b28) into main (3f45d76) will decrease coverage by 11.13%.
The diff coverage is 66.66%.

@@              Coverage Diff              @@
##               main    #1170       +/-   ##
=============================================
- Coverage     75.69%   64.55%   -11.14%     
+ Complexity      862      844       -18     
=============================================
  Files           205      140       -65     
  Lines         10784     3795     -6989     
  Branches        419      406       -13     
=============================================
- Hits           8163     2450     -5713     
+ Misses         2475     1200     -1275     
+ Partials        146      145        -1     
Flag Coverage Δ
controller 64.55% <66.66%> (-0.20%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/ai/starwhale/mlops/datastore/WalManager.java 74.23% <ø> (ø)
...java/ai/starwhale/mlops/datastore/ObjectStore.java 66.66% <66.66%> (ø)
client/starwhale/base/tag.py
client/starwhale/api/_impl/metric.py
client/starwhale/core/dataset/view.py
client/starwhale/utils/log.py
client/starwhale/core/eval/model.py
client/starwhale/base/type.py
client/starwhale/base/store.py
client/starwhale/utils/debug.py
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 920db1f into star-whale:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants