Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(controller): data provider in job support virtual host path #1182

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1182 (08a2a9b) into main (cfd17ee) will decrease coverage by 9.04%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #1182      +/-   ##
============================================
- Coverage     75.93%   66.88%   -9.05%     
- Complexity      897      916      +19     
============================================
  Files           206      144      -62     
  Lines         10866     3971    -6895     
  Branches        412      444      +32     
============================================
- Hits           8251     2656    -5595     
+ Misses         2468     1165    -1303     
- Partials        147      150       +3     
Flag Coverage Δ
controller 66.88% <66.66%> (+0.26%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mlops/storage/configuration/StorageProperties.java 0.00% <0.00%> (ø)
...starwhale/mlops/schedule/k8s/K8sTaskScheduler.java 73.26% <100.00%> (-1.27%) ⬇️
client/starwhale/base/uri.py
client/starwhale/core/job/scheduler.py
client/starwhale/utils/log.py
client/starwhale/api/_impl/data_store.py
client/starwhale/base/store.py
client/starwhale/core/model/default_handler.py
client/starwhale/core/job/dag.py
client/starwhale/utils/progress.py
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 3ca117a into star-whale:main Sep 14, 2022
@jialeicui jialeicui deleted the data-provider branch September 14, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants