Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): use type string name other than category #1191

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working controller 🏘️ labels Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1191 (c3c39be) into main (7560478) will decrease coverage by 13.81%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1191       +/-   ##
=============================================
- Coverage     68.91%   55.10%   -13.82%     
- Complexity     1069     1071        +2     
=============================================
  Files           291      230       -61     
  Lines         13095     6165     -6930     
  Branches        636      636               
=============================================
- Hits           9025     3397     -5628     
+ Misses         3885     2583     -1302     
  Partials        185      185               
Flag Coverage Δ
controller 55.10% <100.00%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/ai/starwhale/mlops/api/DataStoreController.java 87.17% <100.00%> (ø)
.../java/ai/starwhale/mlops/datastore/RecordList.java 100.00% <100.00%> (ø)
...mlops/domain/swds/index/datastore/IndexWriter.java 84.61% <100.00%> (ø)
client/starwhale/utils/fs.py
client/starwhale/utils/flatten.py
client/starwhale/core/job/model.py
client/starwhale/base/mixin.py
client/starwhale/api/_impl/wrapper.py
client/starwhale/base/store.py
client/starwhale/api/_impl/dataset/loader.py
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 3e8a49f into star-whale:main Sep 15, 2022
@jialeicui jialeicui deleted the fix-col-type branch September 15, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants