Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client):exit error code when failed #1192

Merged

Conversation

goldenxinxing
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Sep 14, 2022
@goldenxinxing goldenxinxing self-assigned this Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1192 (ae3339a) into main (5547127) will increase coverage by 5.37%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #1192      +/-   ##
============================================
+ Coverage     75.86%   81.24%   +5.37%     
============================================
  Files           204       62     -142     
  Lines         10828     6926    -3902     
  Branches        409        0     -409     
============================================
- Hits           8215     5627    -2588     
+ Misses         2466     1299    -1167     
+ Partials        147        0     -147     
Flag Coverage Δ
controller ?
standalone 81.24% <66.66%> (+0.02%) ⬆️
unittests 81.24% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/model.py 86.02% <66.66%> (-0.26%) ⬇️
client/starwhale/core/dataset/type.py 82.85% <0.00%> (-0.48%) ⬇️
client/starwhale/api/_impl/model.py 91.66% <0.00%> (-0.29%) ⬇️
client/starwhale/api/_impl/wrapper.py 89.24% <0.00%> (-0.12%) ⬇️
client/starwhale/core/eval/model.py 77.47% <0.00%> (ø)
...ps/domain/task/status/TaskStatusChangeWatcher.java
...java/ai/starwhale/mlops/datastore/OrderByDesc.java
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java
...mlops/domain/swds/index/datastore/IndexWriter.java
...ava/ai/starwhale/mlops/schedule/k8s/K8sClient.java
... and 140 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 0bdc3fa into star-whale:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants