Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datastore): use explicit typing in query instead of guessing type from actual column value #1195

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Sep 14, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1195 (63e01ae) into main (7bcb723) will decrease coverage by 14.63%.
The diff coverage is 68.42%.

@@              Coverage Diff              @@
##               main    #1195       +/-   ##
=============================================
- Coverage     68.22%   53.58%   -14.64%     
+ Complexity     1038     1032        -6     
=============================================
  Files           293      231       -62     
  Lines         13071     6130     -6941     
  Branches        643      634        -9     
=============================================
- Hits           8918     3285     -5633     
+ Misses         3965     2661     -1304     
+ Partials        188      184        -4     
Flag Coverage Δ
controller 53.58% <68.42%> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/ai/starwhale/mlops/datastore/ColumnType.java 87.95% <ø> (+3.16%) ⬆️
...ai/starwhale/mlops/datastore/TableQueryFilter.java 100.00% <ø> (ø)
...va/ai/starwhale/mlops/api/DataStoreController.java 87.17% <57.14%> (+1.28%) ⬆️
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java 85.75% <70.00%> (+0.76%) ⬆️
client/starwhale/core/eval/executor.py
client/starwhale/api/job.py
client/starwhale/api/_impl/dataset/__init__.py
client/starwhale/core/project/model.py
client/starwhale/api/_impl/dataset/builder.py
client/starwhale/core/eval/store.py
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 5abfdaa into star-whale:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants