Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(dataset): fix dataset rows diff error #1204

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

tianweidut
Copy link
Member

Description

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working dataset🐫 labels Sep 15, 2022
@tianweidut tianweidut self-assigned this Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1204 (75910b8) into main (3e8a49f) will increase coverage by 12.24%.
The diff coverage is 16.66%.

@@              Coverage Diff              @@
##               main    #1204       +/-   ##
=============================================
+ Coverage     68.92%   81.17%   +12.24%     
=============================================
  Files           292       62      -230     
  Lines         13097     6937     -6160     
  Branches        636        0      -636     
=============================================
- Hits           9027     5631     -3396     
+ Misses         3885     1306     -2579     
+ Partials        185        0      -185     
Flag Coverage Δ
controller ?
standalone 81.17% <16.66%> (-0.05%) ⬇️
unittests 81.17% <16.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/tabular.py 67.56% <16.66%> (-1.67%) ⬇️
.../mlops/domain/runtime/RuntimeVersionConvertor.java
...arwhale/mlops/memory/impl/SwByteBufferManager.java
...ale/mlops/domain/swmp/po/SwModelPackageEntity.java
...in/java/ai/starwhale/mlops/common/TarFileUtil.java
...configuration/security/JwtAccessDeniedHandler.java
.../java/ai/starwhale/mlops/common/util/HttpUtil.java
.../ai/starwhale/mlops/domain/user/RoleConvertor.java
...hale/mlops/api/protocol/swmp/SwModelPackageVo.java
...tarwhale/mlops/common/util/BatchOperateHelper.java
... and 221 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 11faebf into star-whale:main Sep 15, 2022
@tianweidut tianweidut deleted the fix/dataset-diff branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dataset🐫
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants