Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(controller): add unit tests #1222

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 15, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu self-assigned this Sep 15, 2022
@dreamlandliu dreamlandliu added this to the v0.3 milestone Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1222 (bc3a3d9) into main (7384cb8) will decrease coverage by 11.79%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1222       +/-   ##
=============================================
- Coverage     68.87%   57.08%   -11.80%     
- Complexity     1071     1111       +40     
=============================================
  Files           292      230       -62     
  Lines         13109     6177     -6932     
  Branches        636      636               
=============================================
- Hits           9029     3526     -5503     
+ Misses         3895     2466     -1429     
  Partials        185      185               
Flag Coverage Δ
controller 57.08% <100.00%> (+1.98%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/ai/starwhale/mlops/api/JobController.java 98.21% <100.00%> (+98.21%) ⬆️
.../java/ai/starwhale/mlops/api/SystemController.java 100.00% <100.00%> (+100.00%) ⬆️
...starwhale/mlops/domain/job/BaseImageConvertor.java 100.00% <100.00%> (+100.00%) ⬆️
...java/ai/starwhale/mlops/domain/job/JobManager.java 100.00% <100.00%> (+94.73%) ⬆️
client/starwhale/utils/error.py
client/starwhale/api/metric.py
client/starwhale/utils/progress.py
client/starwhale/api/_impl/job.py
client/starwhale/base/view.py
client/starwhale/api/_impl/dataset/builder.py
... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 68216c6 into star-whale:main Sep 16, 2022
@dreamlandliu dreamlandliu deleted the ut/controller_0914 branch January 6, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants