Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): add ut for client runtime #1230

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1230 (8e1383c) into main (61e1419) will increase coverage by 13.36%.
The diff coverage is n/a.

❗ Current head 8e1383c differs from pull request most recent head 2b63cc3. Consider uploading reports for the commit 2b63cc3 to get more accurate results

@@              Coverage Diff              @@
##               main    #1230       +/-   ##
=============================================
+ Coverage     71.29%   84.65%   +13.36%     
=============================================
  Files           284       62      -222     
  Lines         13100     6968     -6132     
  Branches        639        0      -639     
=============================================
- Hits           9339     5899     -3440     
+ Misses         3563     1069     -2494     
+ Partials        198        0      -198     
Flag Coverage Δ
controller ?
standalone 84.65% <ø> (+2.13%) ⬆️
unittests 84.65% <ø> (+2.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...figuration/security/JwtAuthenticationProvider.java
...e/mlops/configuration/security/JwtLoginFilter.java
...ops/api/protocol/swmp/SwModelPackageVersionVo.java
...e/mlops/domain/evaluation/ViewConfigConvertor.java
...n/java/ai/starwhale/mlops/domain/dag/bo/Graph.java
...va/ai/starwhale/mlops/domain/swds/SwdsManager.java
...ain/java/ai/starwhale/mlops/api/JobController.java
.../ai/starwhale/mlops/domain/project/bo/Project.java
...tarwhale/mlops/domain/bundle/BundleVersionUrl.java
...java/ai/starwhale/mlops/domain/job/JobService.java
... and 218 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut force-pushed the ci/tune-client-ut branch 4 times, most recently from b3654e9 to b1787ec Compare September 16, 2022 13:44
@tianweidut tianweidut changed the title WIP: chore(client): add ut for client WIP: chore(client): add ut for client runtime Sep 16, 2022
@tianweidut tianweidut force-pushed the ci/tune-client-ut branch 8 times, most recently from dc3e7bf to ff15457 Compare September 18, 2022 11:38
@tianweidut tianweidut changed the title WIP: chore(client): add ut for client runtime chore(client): add ut for client runtime Sep 18, 2022
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 6067617 into star-whale:main Sep 19, 2022
@tianweidut tianweidut deleted the ci/tune-client-ut branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants