Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): guest user has permission to see the resource in dataset #1244

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added the chore 🛎️ some tiny change label Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1244 (9fdf4b3) into main (d4b73de) will decrease coverage by 13.07%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1244       +/-   ##
=============================================
- Coverage     74.17%   61.10%   -13.08%     
  Complexity     1173     1173               
=============================================
  Files           284      222       -62     
  Lines         13159     6163     -6996     
  Branches        641      641               
=============================================
- Hits           9761     3766     -5995     
+ Misses         3184     2183     -1001     
  Partials        214      214               
Flag Coverage Δ
controller 61.10% <ø> (ø)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/utils/venv_pack.py
client/starwhale/core/instance/view.py
client/starwhale/core/job/dag.py
client/starwhale/api/_impl/dataset/loader.py
client/starwhale/core/model/model.py
client/starwhale/base/bundle.py
client/starwhale/core/dataset/view.py
client/starwhale/core/eval/executor.py
client/starwhale/utils/log.py
client/starwhale/utils/process.py
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 10448a3 into star-whale:main Sep 19, 2022
@jialeicui jialeicui deleted the data-viewer-permission branch September 20, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants