Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): the project description cannot be set to empty #1268

Merged

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 21, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added bug 🐛 Something isn't working ban-e2e 🚫 labels Sep 21, 2022
@dreamlandliu dreamlandliu added this to the v0.3 milestone Sep 21, 2022
@dreamlandliu dreamlandliu self-assigned this Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1268 (4d0b676) into main (f1c1603) will decrease coverage by 13.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1268       +/-   ##
=============================================
- Coverage     73.84%   60.79%   -13.05%     
  Complexity     1210     1210               
=============================================
  Files           287      225       -62     
  Lines         13378     6349     -7029     
  Branches        651      651               
=============================================
- Hits           9879     3860     -6019     
+ Misses         3277     2267     -1010     
  Partials        222      222               
Flag Coverage Δ
controller 60.79% <ø> (ø)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/runtime/process.py
client/starwhale/utils/process.py
client/starwhale/core/runtime/model.py
client/starwhale/utils/load.py
client/starwhale/consts/__init__.py
client/starwhale/core/dataset/tabular.py
client/starwhale/base/mixin.py
client/starwhale/utils/venv.py
client/starwhale/utils/retry.py
client/starwhale/core/job/model.py
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dreamlandliu dreamlandliu changed the title Fix bugs where the project description cannot be set to empty fix(controller): fix bugs where the project description cannot be set to empty Sep 21, 2022
@dreamlandliu dreamlandliu changed the title fix(controller): fix bugs where the project description cannot be set to empty fix(controller): the project description cannot be set to empty Sep 21, 2022
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 1959fe5 into star-whale:main Sep 21, 2022
@dreamlandliu dreamlandliu deleted the fix/project_description_set_empty branch January 6, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ban-e2e 🚫 bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants