Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): add unique index on project name #1272

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 21, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added the bug 🐛 Something isn't working label Sep 21, 2022
@dreamlandliu dreamlandliu added this to the v0.3 milestone Sep 21, 2022
@dreamlandliu dreamlandliu self-assigned this Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1272 (1d1fbd8) into main (1959fe5) will decrease coverage by 12.97%.
The diff coverage is 83.33%.

@@              Coverage Diff              @@
##               main    #1272       +/-   ##
=============================================
- Coverage     73.86%   60.89%   -12.98%     
- Complexity     1212     1214        +2     
=============================================
  Files           287      225       -62     
  Lines         13390     6367     -7023     
  Branches        651      653        +2     
=============================================
- Hits           9891     3877     -6014     
+ Misses         3277     2267     -1010     
- Partials        222      223        +1     
Flag Coverage Δ
controller 60.89% <83.33%> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...starwhale/mlops/domain/project/ProjectService.java 82.83% <80.00%> (-0.11%) ⬇️
...starwhale/mlops/domain/project/ProjectManager.java 97.72% <100.00%> (ø)
client/starwhale/core/job/model.py
client/starwhale/base/mixin.py
client/starwhale/utils/progress.py
client/starwhale/base/type.py
client/starwhale/core/runtime/model.py
client/starwhale/api/_impl/dataset/__init__.py
client/starwhale/base/cloud.py
client/starwhale/utils/error.py
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 1da63f5 into star-whale:main Sep 22, 2022
@dreamlandliu dreamlandliu deleted the fix/project_name_unique branch January 6, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants