Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dataset): refactor dataset process name to handler #1278

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

tianweidut
Copy link
Member

Description

use the more common name to express dataset processor

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Sep 22, 2022
@tianweidut tianweidut self-assigned this Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1278 (d984ba8) into main (260257c) will increase coverage by 11.76%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1278       +/-   ##
=============================================
+ Coverage     73.87%   85.63%   +11.76%     
=============================================
  Files           287       62      -225     
  Lines         13393     7032     -6361     
  Branches        651        0      -651     
=============================================
- Hits           9894     6022     -3872     
+ Misses         3277     1010     -2267     
+ Partials        222        0      -222     
Flag Coverage Δ
controller ?
standalone 85.63% <100.00%> (ø)
unittests 85.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/model.py 72.36% <100.00%> (ø)
client/starwhale/core/dataset/type.py 99.60% <100.00%> (ø)
.../java/ai/starwhale/mlops/datastore/WalManager.java
...hale/mlops/api/protocol/runtime/RuntimeInfoVo.java
.../mlops/api/protocol/swmp/SwModelPackageInfoVo.java
...e/mlops/domain/swds/converter/SwdsVoConvertor.java
...in/java/ai/starwhale/mlops/storage/StorageUri.java
...arwhale/mlops/memory/impl/SwByteBufferManager.java
...ai/starwhale/mlops/exception/ConvertException.java
...le/mlops/configuration/CommonExceptionHandler.java
... and 217 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 2010565 into star-whale:main Sep 22, 2022
@tianweidut tianweidut deleted the chore/rename-process branch April 17, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants