Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(model): refactor model ppl to handler #1279

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

tianweidut
Copy link
Member

Description

use the more common name to express model evaluator

Modules

  • Client
  • Other

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Sep 22, 2022
@tianweidut tianweidut self-assigned this Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1279 (e031614) into main (e031614) will not change coverage.
The diff coverage is n/a.

❗ Current head e031614 differs from pull request most recent head ab320a0. Consider uploading reports for the commit ab320a0 to get more accurate results

@@            Coverage Diff            @@
##               main    #1279   +/-   ##
=========================================
  Coverage     73.88%   73.88%           
  Complexity     1212     1212           
=========================================
  Files           287      287           
  Lines         13399    13399           
  Branches        651      651           
=========================================
  Hits           9900     9900           
  Misses         3277     3277           
  Partials        222      222           
Flag Coverage Δ
controller 60.87% <0.00%> (ø)
standalone 85.64% <0.00%> (ø)
unittests 85.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

goldenxinxing
goldenxinxing previously approved these changes Sep 22, 2022
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit c2ebecd into star-whale:main Sep 22, 2022
@tianweidut tianweidut deleted the chore/rename-model-ppl branch April 17, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants