Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make step config availabel for UI #1308

Merged
merged 26 commits into from
Oct 9, 2022

Conversation

anda-ren
Copy link
Member

Description

make step config availabel for UI
cc @waynelwz

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1308 (1a6b8b3) into main (6c88294) will increase coverage by 0.44%.
The diff coverage is 80.35%.

@@             Coverage Diff              @@
##               main    #1308      +/-   ##
============================================
+ Coverage     76.36%   76.81%   +0.44%     
- Complexity     1384     1390       +6     
============================================
  Files           293      292       -1     
  Lines         13794    13797       +3     
  Branches        701      700       -1     
============================================
+ Hits          10534    10598      +64     
+ Misses         3017     2958      -59     
+ Partials        243      241       -2     
Flag Coverage Δ
controller 67.26% <84.33%> (+0.95%) ⬆️
standalone 85.54% <68.96%> (-0.08%) ⬇️
unittests 85.54% <68.96%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/view.py 65.43% <ø> (ø)
client/starwhale/core/model/view.py 69.14% <ø> (ø)
...ops/api/protocol/swmp/SwModelPackageVersionVo.java 0.00% <0.00%> (ø)
...ain/java/ai/starwhale/mlops/domain/job/bo/Job.java 50.00% <ø> (ø)
...whale/mlops/domain/job/converter/JobConvertor.java 94.11% <ø> (+4.37%) ⬆️
...starwhale/mlops/domain/runtime/RuntimeService.java 0.49% <ø> (ø)
...arwhale/mlops/domain/swds/upload/SwdsUploader.java 72.35% <ø> (ø)
...java/ai/starwhale/mlops/domain/job/JobService.java 83.89% <42.85%> (-0.98%) ⬇️
client/starwhale/core/eval/model.py 76.95% <50.00%> (-0.58%) ⬇️
client/starwhale/core/model/model.py 84.58% <66.66%> (-1.74%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anda-ren anda-ren added the refactor 🐛 refactor code label Sep 27, 2022
@anda-ren anda-ren added this to the v0.3 milestone Sep 27, 2022
@anda-ren anda-ren self-assigned this Sep 29, 2022
@anda-ren anda-ren marked this pull request as ready for review September 29, 2022 11:46
@anda-ren anda-ren changed the title [WIP]refactor: make step config availabel for UI refactor: make step config availabel for UI Sep 30, 2022
@tianweidut tianweidut self-requested a review October 9, 2022 10:54
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit ae21f56 into star-whale:main Oct 9, 2022
@anda-ren anda-ren deleted the step_config branch October 19, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 🐛 refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants