Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): remove tsc from package #1331

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 8, 2022

Description

Fix CI issue
https://github.com/star-whale/starwhale/actions/runs/3209393519/jobs/5246068593

yarn lint
yarn run v1.22.19
$ eslint -c .eslintrc.js './src/**/*.{ts,tsx}'
Done in 31.9[5](https://github.com/star-whale/starwhale/actions/runs/3209393519/jobs/5246068593#step:8:6)s.
yarn typecheck
yarn run v1.22.19
$ tsc --noEmit -p ./tsconfig.json


                This is not the tsc command you are looking for                


To get access to the TypeScript compiler, tsc, from the command line either:

- Use npm install typescript to first add TypeScript to your project before using npx
- Use yarn to avoid accidentally running code from un-installed packages
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [Makefile:[9](https://github.com/star-whale/starwhale/actions/runs/3209393519/jobs/5246068593#step:8:10): ci-lint] Error 1
Error: Process completed with exit code 2.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit a8f91cc into star-whale:main Oct 8, 2022
@jialeicui jialeicui deleted the fix-tslint-ci branch October 9, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants