Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(client): fix mypy exclude typo and some code lint error #1343

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

tianweidut
Copy link
Member

Description

  • fix mypy exclude typo: ignore some unexpected files
  • fix code lint error

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1343 (d5a9f0d) into main (d351d90) will increase coverage by 8.78%.
The diff coverage is 92.85%.

@@             Coverage Diff              @@
##               main    #1343      +/-   ##
============================================
+ Coverage     76.90%   85.68%   +8.78%     
============================================
  Files           292       64     -228     
  Lines         13828     7244    -6584     
  Branches        700        0     -700     
============================================
- Hits          10634     6207    -4427     
+ Misses         2953     1037    -1916     
+ Partials        241        0     -241     
Flag Coverage Δ
controller ?
standalone 85.68% <92.85%> (+<0.01%) ⬆️
unittests 85.68% <92.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/dataset/builder.py 85.14% <0.00%> (ø)
client/starwhale/utils/venv.py 79.22% <100.00%> (+0.04%) ⬆️
...ale/mlops/domain/task/converter/TaskConvertor.java
...tarwhale/mlops/datastore/impl/MemoryTableImpl.java
...le/mlops/domain/bundle/remove/RemoveException.java
...starwhale/mlops/domain/job/BaseImageConvertor.java
...in/task/status/watchers/TaskWatcherForPersist.java
...starwhale/mlops/domain/storage/StorageService.java
...ain/java/ai/starwhale/mlops/api/LogController.java
...ain/java/ai/starwhale/mlops/api/protocol/Code.java
... and 220 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

client/starwhale/utils/venv.py Outdated Show resolved Hide resolved
client/starwhale/utils/venv.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 08c8674 into star-whale:main Oct 11, 2022
@tianweidut tianweidut deleted the fix/client-mypy-error branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants