Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): terminal execute process on failure #1349

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Oct 12, 2022

Description

  1. terminal execute process when step failure
  2. add log trace print image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1349 (b3af9b0) into main (50e34eb) will increase coverage by 5.73%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##               main    #1349      +/-   ##
============================================
+ Coverage     79.97%   85.71%   +5.73%     
============================================
  Files           294       64     -230     
  Lines         13876     7247    -6629     
  Branches        696        0     -696     
============================================
- Hits          11098     6212    -4886     
+ Misses         2506     1035    -1471     
+ Partials        272        0     -272     
Flag Coverage Δ
controller ?
standalone 85.71% <33.33%> (-0.03%) ⬇️
unittests 85.71% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/job/model.py 95.90% <0.00%> (-0.80%) ⬇️
client/starwhale/core/job/scheduler.py 98.27% <50.00%> (-1.73%) ⬇️
...tarwhale/mlops/StarwhaleControllerApplication.java
...i/starwhale/mlops/domain/job/status/JobStatus.java
...hale/mlops/domain/bundle/revert/RevertManager.java
...java/ai/starwhale/mlops/datastore/ObjectStore.java
...in/java/ai/starwhale/mlops/storage/StorageUri.java
...va/ai/starwhale/mlops/domain/swmp/SwmpManager.java
...arwhale/mlops/memory/impl/SwByteBufferManager.java
...n/java/ai/starwhale/mlops/domain/user/bo/Role.java
... and 222 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@goldenxinxing goldenxinxing force-pushed the chore/add_more_details_for_eval_log branch from 8947b4c to 8e69226 Compare October 13, 2022 08:40
@goldenxinxing goldenxinxing changed the title chore(client): add more details for error log fix(client): terminal execute process on failure Oct 13, 2022
@goldenxinxing goldenxinxing force-pushed the chore/add_more_details_for_eval_log branch from 8e69226 to b3af9b0 Compare October 13, 2022 08:44
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 59adc5b into star-whale:main Oct 13, 2022
@goldenxinxing goldenxinxing deleted the chore/add_more_details_for_eval_log branch May 6, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants