Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): unit test works with macos #1351

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 13, 2022

Description

Unit test works with macOS

  • symlink can not work with virtualenv (not only in macOS)
  • temp dir under macOS is like /var/folders/xx/xxxxxxxxxxxxxxxx/X/, not /tmp/
  • macOS use a symlink temp dir for users

mnist demo can not run under macOS for now, will fix it in further PR.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #1351 (e5d33bc) into main (50e34eb) will increase coverage by 5.73%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1351      +/-   ##
============================================
+ Coverage     79.97%   85.71%   +5.73%     
============================================
  Files           294       64     -230     
  Lines         13876     7247    -6629     
  Branches        696        0     -696     
============================================
- Hits          11098     6212    -4886     
+ Misses         2506     1035    -1471     
+ Partials        272        0     -272     
Flag Coverage Δ
controller ?
standalone 85.71% <ø> (-0.03%) ⬇️
unittests 85.71% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/job/scheduler.py 98.27% <0.00%> (-1.73%) ⬇️
client/starwhale/core/job/model.py 95.90% <0.00%> (-0.80%) ⬇️
...tarwhale/mlops/common/util/BatchOperateHelper.java
...ai/starwhale/mlops/domain/job/cache/JobLoader.java
.../starwhale/mlops/domain/system/agent/bo/Agent.java
...i/starwhale/mlops/memory/SwBufferOutputStream.java
...lops/domain/job/step/status/StepStatusMachine.java
...ai/starwhale/mlops/datastore/TableQueryFilter.java
...in/java/ai/starwhale/mlops/common/IdConvertor.java
...hale/mlops/domain/bundle/remove/RemoveManager.java
... and 222 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui force-pushed the work-with-macos branch 2 times, most recently from fb6ab39 to 7464a67 Compare October 13, 2022 08:48
@jialeicui jialeicui marked this pull request as draft October 13, 2022 09:19
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 824708f into star-whale:main Oct 13, 2022
@jialeicui jialeicui deleted the work-with-macos branch October 13, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants