Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(sdk): add map type support #1499

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Nov 14, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

tianweidut
tianweidut previously approved these changes Nov 14, 2022
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #1499 (5161d30) into main (ed530f9) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
+ Coverage   87.78%   87.80%   +0.02%     
==========================================
  Files          66       66              
  Lines        7718     7797      +79     
==========================================
+ Hits         6775     6846      +71     
- Misses        943      951       +8     
Flag Coverage Δ
standalone 87.80% <90.00%> (+0.02%) ⬆️
unittests 87.80% <90.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/data_store.py 94.10% <90.00%> (-0.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut merged commit 6921368 into star-whale:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants