Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(client): rich print null when table have too many cols #1534

Merged
merged 1 commit into from
Nov 21, 2022
Merged

chore(client): rich print null when table have too many cols #1534

merged 1 commit into from
Nov 21, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 18, 2022 •
edited
Loading

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the chore 🛎️ some tiny change label Nov 18, 2022
@goldenxinxing goldenxinxing self-assigned this Nov 18, 2022
@goldenxinxing goldenxinxing changed the title chore(client): rich print table bug when cols too many WIP chore(client): rich print table bug when cols too many Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022 •
edited
Loading

Codecov Report

Merging #1534 (5c13f32) into main (4c9e8ba) will increase coverage by 6.23%.
The diff coverage is 73.33%.

@@             Coverage Diff              @@
##               main    #1534      +/-   ##
============================================
+ Coverage     82.06%   88.30%   +6.23%     
============================================
  Files           327       70     -257     
  Lines         16040     8116    -7924     
  Branches        855        0     -855     
============================================
- Hits          13164     7167    -5997     
+ Misses         2529      949    -1580     
+ Partials        347        0     -347
Flag Coverage Δ
controller ?
standalone 88.30% <73.33%> (+0.11%) ⬆️
unittests 88.30% <73.33%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/model.py 77.39% <ø> (+0.43%) ⬆️
client/starwhale/core/eval/view.py 70.40% <71.42%> (+4.96%) ⬆️
client/starwhale/consts/__init__.py 100.00% <100.00%> (ø)
client/starwhale/api/_impl/dataset/loader.py 95.38% <0.00%> (-2.64%) ⬇️
client/starwhale/core/dataset/type.py 98.78% <0.00%> (-1.22%) ⬇️
client/starwhale/core/dataset/tabular.py 96.80% <0.00%> (-0.68%) ⬇️
...e/mlops/api/protocol/system/UpgradeProgressVo.java
...n/java/ai/starwhale/mlops/domain/user/bo/User.java
...tarwhale/mlops/domain/bundle/BundleVersionUrl.java
...mlops/domain/task/status/WatchableTaskFactory.java
... and 257 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@goldenxinxing goldenxinxing changed the title WIP chore(client): rich print table bug when cols too many WIP chore(client): rich print null when table have too many cols Nov 18, 2022
@goldenxinxing goldenxinxing force-pushed the fix/rich_print_none_when_too_many_cols branch from ec96916 to 2d3781c Compare November 18, 2022 09:07
@goldenxinxing goldenxinxing changed the title WIP chore(client): rich print null when table have too many cols chore(client): rich print null when table have too many cols Nov 18, 2022
@goldenxinxing goldenxinxing force-pushed the fix/rich_print_none_when_too_many_cols branch 2 times, most recently from 6b0fca9 to 0c7ce8c Compare November 18, 2022 10:08
@tianweidut
Copy link
Member

Others LGTM

@goldenxinxing add some ut?

@goldenxinxing goldenxinxing force-pushed the fix/rich_print_none_when_too_many_cols branch from 0c7ce8c to 5c13f32 Compare November 21, 2022 03:26
@goldenxinxing
Copy link
Contributor Author

Others LGTM

@goldenxinxing add some ut?

done

@tianweidut tianweidut self-requested a review November 21, 2022 05:09
tianweidut
tianweidut approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit a711ac9 into star-whale:main Nov 21, 2022
@goldenxinxing goldenxinxing deleted the fix/rich_print_none_when_too_many_cols branch April 27, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

Assignees

@goldenxinxing goldenxinxing

Labels
chore 🛎️ some tiny change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @tianweidut