Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): e2e test for remove/recover trash and fix bug #1571

Merged
merged 8 commits into from
Dec 2, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Dec 1, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added this to the v0.3.3 milestone Dec 1, 2022
@dreamlandliu dreamlandliu self-assigned this Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #1571 (845ebe2) into main (8a43bae) will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1571      +/-   ##
============================================
+ Coverage     81.51%   81.93%   +0.42%     
- Complexity     1823     1832       +9     
============================================
  Files           330      330              
  Lines         16479    16482       +3     
  Branches        910      910              
============================================
+ Hits          13433    13505      +72     
+ Misses         2671     2596      -75     
- Partials        375      381       +6     
Flag Coverage Δ
controller 75.33% <100.00%> (+0.84%) ⬆️
standalone 88.58% <ø> (ø)
unittests 88.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arwhale/mlops/domain/dataset/po/DatasetEntity.java 100.00% <ø> (ø)
...i/starwhale/mlops/domain/model/po/ModelEntity.java 100.00% <ø> (ø)
...arwhale/mlops/domain/runtime/po/RuntimeEntity.java 100.00% <ø> (ø)
...ale/mlops/domain/dataset/mapper/DatasetMapper.java 87.50% <100.00%> (+87.50%) ⬆️
...arwhale/mlops/domain/model/mapper/ModelMapper.java 87.50% <100.00%> (+87.50%) ⬆️
...ale/mlops/domain/runtime/mapper/RuntimeMapper.java 87.50% <100.00%> (+87.50%) ⬆️
.../ai/starwhale/mlops/domain/dataset/DatasetDao.java 72.00% <0.00%> (+6.00%) ⬆️
...java/ai/starwhale/mlops/domain/model/ModelDao.java 76.92% <0.00%> (+7.69%) ⬆️
.../ai/starwhale/mlops/domain/runtime/RuntimeDao.java 76.92% <0.00%> (+7.69%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit ed4cec0 into star-whale:main Dec 2, 2022
@dreamlandliu dreamlandliu deleted the ut/trash_1201 branch January 6, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants