Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): support cloud remote dataset build by dataset sdk #1606

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Dec 12, 2022

Description

asciicast
image

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3.4 milestone Dec 12, 2022
@tianweidut tianweidut self-assigned this Dec 12, 2022
@tianweidut tianweidut changed the title feat(sdk): support cloud remote dataset build by dataset sdk WIP feat(sdk): support cloud remote dataset build by dataset sdk Dec 12, 2022
@tianweidut tianweidut force-pushed the feat/dataset-for-cloud-build branch 3 times, most recently from 56716b2 to a7794b9 Compare December 12, 2022 14:09
@tianweidut tianweidut changed the title WIP feat(sdk): support cloud remote dataset build by dataset sdk feat(sdk): support cloud remote dataset build by dataset sdk Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1606 (c107940) into main (1f67118) will increase coverage by 7.27%.
The diff coverage is 98.05%.

@@             Coverage Diff              @@
##               main    #1606      +/-   ##
============================================
+ Coverage     82.51%   89.79%   +7.27%     
============================================
  Files           340       78     -262     
  Lines         17466     9207    -8259     
  Branches        930        0     -930     
============================================
- Hits          14412     8267    -6145     
+ Misses         2660      940    -1720     
+ Partials        394        0     -394     
Flag Coverage Δ
controller ?
standalone 89.79% <98.05%> (+0.12%) ⬆️
unittests 89.79% <98.05%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/tabular.py 97.11% <ø> (ø)
client/starwhale/core/dataset/copy.py 96.42% <89.47%> (-3.58%) ⬇️
client/starwhale/api/_impl/dataset/builder.py 96.91% <100.00%> (+<0.01%) ⬆️
client/starwhale/api/_impl/dataset/model.py 99.74% <100.00%> (+0.02%) ⬆️
client/starwhale/api/_impl/wrapper.py 94.44% <100.00%> (ø)
client/starwhale/base/bundle_copy.py 97.57% <100.00%> (+0.10%) ⬆️
client/starwhale/core/dataset/model.py 97.79% <100.00%> (-0.40%) ⬇️
client/starwhale/core/model/copy.py 71.87% <100.00%> (+1.87%) ⬆️
client/starwhale/api/_impl/model.py 90.90% <0.00%> (-0.06%) ⬇️
... and 270 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut force-pushed the feat/dataset-for-cloud-build branch 2 times, most recently from 0752efa to 5b67e15 Compare December 13, 2022 05:32
@tianweidut tianweidut marked this pull request as ready for review December 13, 2022 05:42
@tianweidut tianweidut requested review from goldenxinxing, anda-ren and jialeicui and removed request for goldenxinxing December 13, 2022 05:43
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tianweidut tianweidut merged commit 1d9f386 into star-whale:main Dec 14, 2022
@tianweidut tianweidut deleted the feat/dataset-for-cloud-build branch April 14, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants