Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): support runtime replace image registry #2345

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Jun 13, 2023

Description

related: #2305 #2306

  1. client: runtime dockerize use new image rule
  2. server: runtime version's image support replace registry

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing self-assigned this Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2345 (b3bd7d5) into main (dfaac24) will increase coverage by 0.03%.
The diff coverage is 72.91%.

@@             Coverage Diff              @@
##               main    #2345      +/-   ##
============================================
+ Coverage     82.55%   82.59%   +0.03%     
- Complexity     2424     2439      +15     
============================================
  Files           429      428       -1     
  Lines         22752    22707      -45     
  Branches       1327     1318       -9     
============================================
- Hits          18784    18755      -29     
+ Misses         3367     3350      -17     
- Partials        601      602       +1     
Flag Coverage Δ
console ?
controller 74.54% <72.34%> (+0.05%) ⬆️
standalone 91.11% <100.00%> (+0.02%) ⬆️
unittests 91.11% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tarwhale/mlops/domain/job/ModelServingService.java 72.90% <50.00%> (+0.10%) ⬆️
...ale/mlops/domain/job/converter/JobBoConverter.java 91.42% <50.00%> (+0.08%) ⬆️
.../mlops/domain/runtime/po/RuntimeVersionEntity.java 61.11% <58.82%> (-38.89%) ⬇️
...starwhale/mlops/domain/runtime/RuntimeService.java 77.59% <80.00%> (+0.62%) ⬆️
...in/java/ai/starwhale/mlops/common/DockerImage.java 86.95% <83.33%> (-13.05%) ⬇️
client/starwhale/core/runtime/model.py 93.55% <100.00%> (ø)
...ain/runtime/converter/RuntimeVersionConverter.java 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@tianweidut
Copy link
Member

Others LGTM

@tianweidut tianweidut merged commit da2f75d into star-whale:main Jun 14, 2023
@goldenxinxing goldenxinxing deleted the feat/support_runtime_replace_image_registry branch June 30, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants