-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): support runtime replace image registry #2345
Merged
tianweidut
merged 8 commits into
star-whale:main
from
goldenxinxing:feat/support_runtime_replace_image_registry
Jun 14, 2023
Merged
feat(runtime): support runtime replace image registry #2345
tianweidut
merged 8 commits into
star-whale:main
from
goldenxinxing:feat/support_runtime_replace_image_registry
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2345 +/- ##
============================================
+ Coverage 82.55% 82.59% +0.03%
- Complexity 2424 2439 +15
============================================
Files 429 428 -1
Lines 22752 22707 -45
Branches 1327 1318 -9
============================================
- Hits 18784 18755 -29
+ Misses 3367 3350 -17
- Partials 601 602 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tianweidut
reviewed
Jun 14, 2023
Others LGTM |
tianweidut
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related: #2305 #2306
Modules
Checklist