Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataset): support dataset builf from audio/video/image folder #2371

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Jun 19, 2023

Description

Modules

  • Client
  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #2371 (e26f2c8) into main (2bb9711) will increase coverage by 8.52%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2371      +/-   ##
============================================
+ Coverage     82.57%   91.09%   +8.52%     
============================================
  Files           429       98     -331     
  Lines         22872    11146   -11726     
  Branches       1347        0    -1347     
============================================
- Hits          18886    10154    -8732     
+ Misses         3377      992    -2385     
+ Partials        609        0     -609     
Flag Coverage Δ
console ?
controller ?
standalone 91.09% <100.00%> (+0.06%) ⬆️
unittests 91.09% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/dataset/model.py 98.80% <100.00%> (+0.15%) ⬆️
client/starwhale/base/type.py 100.00% <100.00%> (ø)
client/starwhale/core/dataset/model.py 94.48% <100.00%> (+0.23%) ⬆️
client/starwhale/core/dataset/type.py 94.22% <100.00%> (+0.03%) ⬆️
client/starwhale/core/dataset/view.py 63.22% <100.00%> (+1.48%) ⬆️

... and 331 files with indirect coverage changes

@tianweidut tianweidut force-pushed the feat/dataset-from-folder branch 3 times, most recently from a5dc1e7 to 9d7394a Compare June 20, 2023 03:28
@tianweidut tianweidut marked this pull request as ready for review June 20, 2023 03:31
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit e4ca9e8 into star-whale:main Jun 20, 2023
@tianweidut tianweidut deleted the feat/dataset-from-folder branch September 5, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants