Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): make all the shared resource unshared when project change to private #2455

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui force-pushed the private-proj branch 2 times, most recently from e903ebb to 283a1f7 Compare July 5, 2023 06:42
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2455 (283a1f7) into main (fb0a876) will decrease coverage by 15.00%.
The diff coverage is 58.33%.

❗ Current head 283a1f7 differs from pull request most recent head 4af7f65. Consider uploading reports for the commit 4af7f65 to get more accurate results

@@              Coverage Diff              @@
##               main    #2455       +/-   ##
=============================================
- Coverage     91.06%   76.06%   -15.00%     
- Complexity        0     2593     +2593     
=============================================
  Files           101      335      +234     
  Lines         11740    12091      +351     
  Branches         14     1398     +1384     
=============================================
- Hits          10691     9197     -1494     
- Misses         1049     2257     +1208     
- Partials          0      637      +637     
Flag Coverage Δ
console ?
controller 76.06% <58.33%> (?)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ps/domain/dataset/mapper/DatasetVersionMapper.java 0.00% <ø> (ø)
.../mlops/domain/dataset/po/DatasetVersionEntity.java 100.00% <ø> (ø)
.../mlops/domain/model/mapper/ModelVersionMapper.java 80.64% <ø> (ø)
...hale/mlops/domain/model/po/ModelVersionEntity.java 100.00% <ø> (ø)
.../ai/starwhale/mlops/domain/project/bo/Project.java 76.92% <0.00%> (ø)
...ps/domain/runtime/mapper/RuntimeVersionMapper.java 29.72% <ø> (ø)
.../mlops/domain/runtime/po/RuntimeVersionEntity.java 61.11% <ø> (ø)
...starwhale/mlops/domain/project/ProjectService.java 71.01% <60.00%> (ø)
...java/ai/starwhale/mlops/api/ProjectController.java 85.71% <100.00%> (ø)

... and 427 files with indirect coverage changes

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 99325a6 into star-whale:main Jul 6, 2023
@jialeicui jialeicui deleted the private-proj branch July 6, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants