-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller): page not working #2540
fix(controller): page not working #2540
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2540 +/- ##
============================================
- Coverage 82.79% 74.73% -8.06%
- Complexity 2654 2658 +4
============================================
Files 451 348 -103
Lines 24530 12582 -11948
Branches 1482 1469 -13
============================================
- Hits 20309 9403 -10906
+ Misses 3567 2524 -1043
- Partials 654 655 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
btw, add some UT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Modules
Checklist