Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SDK): support image mode convert for Image type #3010

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1281ba8) 82.73% compared to head (72180ce) 92.06%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3010      +/-   ##
============================================
+ Coverage     82.73%   92.06%   +9.33%     
============================================
  Files           555      124     -431     
  Lines         30355    14969   -15386     
  Branches       1831        0    -1831     
============================================
- Hits          25113    13781   -11332     
+ Misses         4433     1188    -3245     
+ Partials        809        0     -809     
Flag Coverage Δ
console ?
controller ?
standalone 92.06% <100.00%> (+0.01%) ⬆️
unittests 92.06% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 82f9b96 into star-whale:main Nov 22, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants