Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add more filter for model tree #3013

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 22, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34d2018) 91.62% compared to head (142ade0) 91.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3013      +/-   ##
==========================================
+ Coverage   91.62%   91.84%   +0.21%     
==========================================
  Files         129      126       -3     
  Lines       15251    15037     -214     
  Branches       61        0      -61     
==========================================
- Hits        13974    13810     -164     
+ Misses       1275     1227      -48     
+ Partials        2        0       -2     
Flag Coverage Δ
console ?
standalone 91.84% <100.00%> (-0.07%) ⬇️
unittests 91.84% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldenxinxing goldenxinxing marked this pull request as draft November 22, 2023 07:35
@goldenxinxing goldenxinxing marked this pull request as ready for review November 22, 2023 09:52
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit cdae936 into star-whale:main Nov 23, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants